commit | 48a0a74df4aa75e223898dd562da4ae4bb9df456 | [log] [tgz] |
---|---|---|
author | Stephen McGruer <[email protected]> | Mon Jan 20 20:08:14 2025 |
committer | Copybara-Service <[email protected]> | Mon Jan 20 20:13:48 2025 |
tree | 8d47a90273632abf8fa3e2f19378fd65f4fa7a62 | |
parent | ff7821fdd8ffbe25e56ec594b6b336d2a9ebd57a [diff] |
Revert "private_code_test: Parse build.ninja to collect linker inputs" This reverts commit a6dddc3de16b5c67656254e10ed648354cd3a4f0. Reason for revert: Suspected of causing failure in deterministic build - https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux/51954 (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8725202020735429233/+/u/compare_build_artifacts/stdout) Original change's description: > private_code_test: Parse build.ninja to collect linker inputs > > Although slower, this handles the case where GN targets are in public > code, but include source files from private code. > > Bug: 40204298 > Change-Id: If571518f07855946a16e5aeebe0cace661cc75dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5756917 > Commit-Queue: Andrew Grieve <[email protected]> > Reviewed-by: Dirk Pranke <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1408713} Bug: 40204298 Change-Id: I9584a8e46d28ce0f64d263c88d8041cb51368471 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6184083 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Andrew Grieve <[email protected]> Reviewed-by: Dirk Pranke <[email protected]> Commit-Queue: Andrew Grieve <[email protected]> Cr-Commit-Position: refs/heads/main@{#1408751} NOKEYCHECK=True GitOrigin-RevId: 83e7953b9679c76170adf1b02e13e129e3c6de75
//build
contains:
Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium, v8, etc), it should be kept as self-contained as possible by not referring to files outside of it. Some exceptions exist (//testing
, select //third_party
subdirectories), but new dependencies tend to break these other projects, and so should be avoided.
Changes to //build
should be landed in the Chromium repo. They will then be replicated to the stand-alone build repo by the gsubtreed tool. Note: You can find all directories already available through gsubtreed in the list of all chromium repos.
//build/config
- Common templates via .gni
files.//build/toolchain
- GN toolchain definitions.Other .py files
- Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.Files referenced by //.gn
:
//build/BUILDCONFIG.gn
- Included by all BUILD.gn
files.//build/secondary
- An overlay for BUILD.gn
files. Enables adding BUILD.gn
to directories that live in sub-repositories.//build_overrides
- Refer to //build_overrides/README.md.